You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
App watcher now has the responsibility of building extensions when they change.
For extensions that use ESBuild, it handles that using using contexts.
Having a unified place for watching and building extensions during dev is very convenient, as the events from here can be used by the different processes running during dev:
Legacy partners draft update
New management api updates
Previewable extensions using the dev console
...
WHAT is this pull request doing?
The App Watcher will now build extensions:
At start, build all extensions
On every change, rebuild the affected extensions.
Remove the UpdatedSource event type for the watcher.
For extensions using ESBuild: use esbuild contexts to handle incremental builds (which means: faster builds)
All build artifacts are generated in the local .shopify directory by default.
Update the new dev flow to use this new feature.
How to test your changes?
Having an app with different extensions (specially ui-extensions and functions):
Run pnpm shopify demo watcher --path <path_to_app>
Open the .shopify/bundle directory, you should see all the built extensions.
Make a change in an extension with source code, it should update the built artifact.
Alternative: Having an org in app-management, run dev with the new API.
Post-release steps
Measuring impact
How do we know this change was effective? Please choose one:
n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
Existing analytics will cater for this addition
PR includes analytics changes to measure impact
Checklist
I've considered possible cross-platform impacts (Mac, Linux, Windows)
We detected some changes at either packages/*/src or packages/cli-kit/assets/cli-ruby/** and there are no updates in the .changeset.
If the changes are user-facing, run "pnpm changeset add" to track your changes and include them in the next release CHANGELOG.
This PR seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action.
→ If there's no activity within a week, then a bot will automatically close this.
Thanks for helping to improve Shopify's dev tooling and experience.
We detected some changes at packages/*/src and there are no updates in the .changeset.
If the changes are user-facing, run "pnpm changeset add" to track your changes and include them in the next release CHANGELOG.
🫰✨ Thanks @isaacroldan! Your snapshot has been published to npm.
Test the snapshot by intalling your package globally:
pnpm i -g @shopify/cli@0.0.0-snapshot-20241024163114
After installing, validate the version by running just shopify in your terminal
If the versions don't match, you might have multiple global instances installed.
Use which shopify to find out which one you are running and uninstall it.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
App watcher now has the responsibility of building extensions when they change.
For extensions that use ESBuild, it handles that using using contexts.
Having a unified place for watching and building extensions during dev is very convenient, as the events from here can be used by the different processes running during
dev:WHAT is this pull request doing?
UpdatedSourceevent type for the watcher..shopifydirectory by default.devflow to use this new feature.How to test your changes?
Having an app with different extensions (specially ui-extensions and functions):
pnpm shopify demo watcher --path <path_to_app>.shopify/bundledirectory, you should see all the built extensions.Alternative: Having an org in app-management, run
devwith the new API.Post-release steps
Measuring impact
How do we know this change was effective? Please choose one:
Checklist